refactor(cookie_store): remove universal_io dependency.#2413
Merged
Conversation
Signed-off-by: Nikolas Rimikis <leptopoda@users.noreply.github.com>
Member
|
So you can use it on web, even though it comes from dart:io? |
Member
Author
|
Yes. Most of dartio can also be used on web. https://github.com/dint-dev/universal_io/blob/master/lib/src/_exports_in_browser.dart If you also take a look at the |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2413 +/- ##
==========================================
- Coverage 26.40% 26.38% -0.02%
==========================================
Files 370 370
Lines 136662 136719 +57
==========================================
- Hits 36086 36075 -11
- Misses 100576 100644 +68
*This pull request uses carry forward flags. Click here to find out more.
|
provokateurin
approved these changes
Aug 21, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
Cookiedoes not depend on the dart vm and is therefore also usable on web.To verify this, I've also enabled unit tests on chrome.